[Asterisk-code-review] res_pjsip_sdp_rtp.c: Use correct timeout when put on hold. (asterisk[20])

[Benjamin Keith Ford]

Attention is currently required from: Joshua Colp.

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19709 )

Change subject: res_pjsip_sdp_rtp.c: Use correct timeout when put on hold.
......................................................................


Patch Set 2:

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19709/comment/2e510297_75c01047 
PS1, Line 15: ASTDEV-29
> This should have an ASTERISK issue.
Done


File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/19709/comment/a9969180_3ed8f0cf 
PS1, Line 2247: 	} else if (session->endpoint->media.rtp.timeout_hold && !session_media->remotely_held && session_media->locally_held) {
> I don't think you need to add another else if. The existing remotely_held block can just be used: […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19709
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I7b106fc244332014216d12bba851cefe884cc25f
Gerrit-Change-Number: 19709
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 12 Dec 2022 19:15:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221212/7ffd2d22/attachment.html>