[Asterisk-code-review] res_pjsip_sdp_rtp.c: Use correct timeout when put on hold. (asterisk[20])

Benjamin Keith Ford asteriskteam at digium.com
Mon Dec 12 13:14:18 CST 2022


Attention is currently required from: Benjamin Keith Ford.

Hello Joshua Colp, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/19709

to look at the new patch set (#2).

Change subject: res_pjsip_sdp_rtp.c: Use correct timeout when put on hold.
......................................................................

res_pjsip_sdp_rtp.c: Use correct timeout when put on hold.

When a call is put on hold and it has moh_passthrough and rtp_timeout
set on the endpoint, the wrong timeout will be used. rtp_timeout_hold is
expected to be used, but rtp_timeout is used instead. This change adds a
couple of checks for locally_held to determine if rtp_timeout_hold needs
to be used instead of rtp_timeout.

ASTERISK-30350

Change-Id: I7b106fc244332014216d12bba851cefe884cc25f
---
M res/res_pjsip_sdp_rtp.c
1 file changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/09/19709/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19709
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I7b106fc244332014216d12bba851cefe884cc25f
Gerrit-Change-Number: 19709
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221212/d1c26824/attachment.html>


More information about the asterisk-code-review mailing list