[Asterisk-code-review] res_http_media_cache: Allow to customize parameters (asterisk[20])

[Joshua Colp]

Attention is currently required from: N A, Holger Hans Peter Freyther.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Allow to customize parameters
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/902b5bcf_efc00893 
PS1, Line 52: 			</configObject>
> I am happy to squash them. I split them up to make it easier for review. […]
I think they should be squashed.


File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/4ce1c80c_2cd64d88 
PS2, Line 49: 				<configOption name="maxrdirects" default="8">
misrdirects instead of misredirects


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/33adea1e_7c89d5bc 
PS2, Line 580: 	cfg = ast_config_load("res_http_media_cache.conf", config_flags);
This is the old style of configuration files. It is highly preferred that ACO be used, which would have caught the XML documentation error, and also would allow reload support and enforcement of values - along with defaults. An example exists in apps/app_skel.c for it.

res/res_statsd.c also uses it, and has an example of using defaults.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Comment-Date: Mon, 12 Dec 2022 14:29:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221212/dfbd5591/attachment.html>