[Asterisk-code-review] res_http_media_cache: Allow to customize parameters (asterisk[20])

[N A]

Attention is currently required from: Holger Hans Peter Freyther.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Allow to customize parameters
......................................................................


Patch Set 2:

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/890bfd27_6929500f 
PS1, Line 10: but don't make it mandatory yet.
> I don't know the policy on breaking changes. […]
It should not be made mandatory now (as that would be a breaking change), I'm just a bit curious as to the need to make it mandatory in the future.


Patchset:

PS1: 
> Does it make sense to ignore missing files?
It would depend on the module and what the file is used for. Missing files can (and should) be safely ignored if there are sane defaults.
If there is a plan to make the config file mandatory in the future (which may or may not make sense), then it should probably throw a warning in anticipation of that. If the file is not actually needed though, I don't know if it's necessary to anticipate making it mandatory in the future.

> Is there one good example of how to handle it?
Lots of other files load configs, you can use any as an example: https://github.com/asterisk/asterisk/search?p=2&q=ast_config_load&type=


File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/854897bd_08c326ee 
PS1, Line 578: 	if (cfg == CONFIG_STATUS_FILEMISSING) {
> Done. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Comment-Date: Sat, 10 Dec 2022 12:39:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221210/6759b67d/attachment.html>