[Asterisk-code-review] chan_sip: Remove deprecated module. (testsuite[master])

N A asteriskteam at digium.com
Tue Dec 6 15:41:07 CST 2022


Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/19612 )

Change subject: chan_sip: Remove deprecated module.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/testsuite/+/19612/comment/1ac788c4_862bfd3d 
PS1, Line 7: chan_sip: Remove deprecated module.
Just for the sake of clarity, perhaps "Remove tests for deprecated/removed module"?


Patchset:

PS1: 
I thought there was some mention of SIP tests being migrated to PJSIP (not tests for chan_sip, but that happen to use SIP instead of PJSIP to test something). Has that all already been completed?

For example, tests/feature_call_pickup/configs/ast1/sip.conf

I'm assuming these tests will all start failing, or at least become irrelevant, once chan_sip is removed.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/19612
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Ic544456498eee5eb2514d27e2c7a4f004bdf8273
Gerrit-Change-Number: 19612
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 06 Dec 2022 21:41:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221206/06a53922/attachment.html>


More information about the asterisk-code-review mailing list