<p> Attention is currently required from: Michael Bradeen. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/19612">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/19612/comment/1ac788c4_862bfd3d">Patch Set #1, Line 7:</a> <code style="font-family:monospace,monospace">chan_sip: Remove deprecated module.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just for the sake of clarity, perhaps "Remove tests for deprecated/removed module"?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/19612?tab=comments">Patch Set #1:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">I thought there was some mention of SIP tests being migrated to PJSIP (not tests for chan_sip, but that happen to use SIP instead of PJSIP to test something). Has that all already been completed?</p><p style="white-space: pre-wrap; word-wrap: break-word;">For example, tests/feature_call_pickup/configs/ast1/sip.conf</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm assuming these tests will all start failing, or at least become irrelevant, once chan_sip is removed.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/19612">change 19612</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/19612"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic544456498eee5eb2514d27e2c7a4f004bdf8273 </div>
<div style="display:none"> Gerrit-Change-Number: 19612 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: N A <asterisk@phreaknet.org> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Dec 2022 21:41:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>