[Asterisk-code-review] res_pjsip: return all codecs on a re-INVITE without SDP (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Henning Westerholt.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18990 )

Change subject: res_pjsip: return all codecs on a re-INVITE without SDP
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

Patchset:

PS3: 
This also needs an Alembic migration script[1] since this adds a new option. There is a sample config script in contrib/ast-db-manage which can be passed to alembic using the -c option. You can look through past migration scripts to see how the Python is done.

[1] https://alembic.sqlalchemy.org/en/latest/tutorial.html#create-a-migration-script


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/1e9206dc_5fcd6241 
PS3, Line 1281:                     ; Return all codecs on empty re-INVITE.
This needs to be more thoroughly documented about what it actually does. For example:

On reception of a re-INVITE without SDP Asterisk will send an SDP offer in the 200 OK response containing all configured codecs on the endpoint, instead of simply those that have already been negotiated.


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/c4171d0b_ff90ad68 
PS3, Line 2077: 						Return all codecs on empty re-INVITE. RFC 3261
Comment I provided per sample config also applies here


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/8207606f_ae601cb3 
PS3, Line 5067: 		if (session->active_media_state->topology && !answer_all_codecs) {
If there are multiple streams, what is the consequence of not using the active media state topology? What is the resulting SDP like? Should the variable name instead reflect what it is actually doing, that is: ignoring active stream topology



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18990
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148
Gerrit-Change-Number: 18990
Gerrit-PatchSet: 3
Gerrit-Owner: Henning Westerholt <hw at gilawa.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Henning Westerholt <hw at gilawa.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 11:06:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220829/62e5272c/attachment.html>