[Asterisk-code-review] res_pjsip: return all codecs on a re-INVITE without SDP (asterisk[16])

[Henning Westerholt]

Attention is currently required from: N A.
Henning Westerholt has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18990 )

Change subject: res_pjsip: return all codecs on a re-INVITE without SDP
......................................................................


Patch Set 3:

(7 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/e72fdef1_bf2d019b 
PS2, Line 8: 
> Wrap commit message at 72 characters to avoid wrapping
Done


Patchset:

PS3: 
Thanks, should be done now


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/06488fb4_f401c70b 
PS2, Line 1281:                     ; If we should return all codecs on empty re-INVITE.
> I don't think "If we should" is necessary, and just starting with "Return" is clearer to me. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/3a60a870_206764c6 
PS2, Line 1282:                     ; RFC 3261 specify it SHOULD be done like this.
> specifies
Done


File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/419b4034_ec56346e 
PS2, Line 3505:  * \since unreleased
> I don't think \since unreleased is needed
Done


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/09cdf03d_fa7c6473 
PS2, Line 2078: 						specify this as a SHOULD requirement.
> specifies
Done


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/c7e2f810_2afa152d 
PS2, Line 5231: 	ast_trace(-1, "session_inv_on_create_offer\n");
> Should the -1 be 1?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18990
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148
Gerrit-Change-Number: 18990
Gerrit-PatchSet: 3
Gerrit-Owner: Henning Westerholt <hw at gilawa.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 26 Aug 2022 14:30:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220826/ff62a747/attachment-0001.html>