[Asterisk-code-review] testuite: Python3 support ASTERISK-26826 (testsuite[16])

[George Joseph]

Attention is currently required from: Michael Bradeen, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18962 )

Change subject: testuite: Python3 support ASTERISK-26826
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

Patchset:

PS4: 
I think you missed tests/codecs/rtp_analyzer.py.  Do you have codec_opus installed?

File "/usr/src/asterisk/testsuite/tests/codecs/rtp_analyzer.py", line 65, in __init__
pcap_config = dict(pcap_defaults.items() + module_config.items())
TypeError: unsupported operand type(s) for +: 'dict_items' and 'dict_items'

For python 3, it should be
pcap_config = dict(pcap_defaults, **module_config)

Per my comment on the review for the asterisk part, we should move the venv creation here so the testsuite can be run directly.


File tests/channels/pjsip/transfers/attended_transfer/nominal/callee_local_direct_media/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/c564e3d8_508bd1d7 
PS4, Line 1: testinfo:
This test always fails for me...

Running tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media ...
[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:572 processEnded: b"Resolving remote host '127.0.0.1'... Done.n"
[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:572 processEnded: b'2022-08-22t05:52:04.186904t1661169124.186904: sendCmdBuffer returned -1nThere were more errors, enable -trace_err to log them.n'
[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:675 __scenario_callback: SIPp Scenario referer.xml Failed [1]
[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:849 __scenario_callback: Coordinated SIPp Scenario 5080 Failed
[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:684 __evaluate_scenario_results: SIPp Scenario referer.xml Failed
[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:536 kill: Killing SIPp Scenario wait-for-a-call.xml
[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:536 kill: Killing SIPp Scenario wait-for-a-call-then-send-bye.xml
[Aug 22 05:52:04] WARNING[3775069]: asterisk.sipp:231 _handle_scenario_finished: Scenario Coordinated Scenario 5080 failed
[Aug 22 05:52:49] WARNING[3775069]: asterisk.asterisk:598 __send_kill: Sending KILL to Asterisk 127.0.0.1
Test tests/channels/pjsip/transfers/attended_transfer/nominal/caller_local_direct_media failed



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18962
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: Id22c8f7a89e2d00fca760970af63f3954c049bf3
Gerrit-Change-Number: 18962
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 22 Aug 2022 12:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220822/6f6c4f66/attachment.html>