[Asterisk-code-review] testuite: Python3 support ASTERISK-26826 (testsuite[16])

[Michael Bradeen]

Attention is currently required from: Joshua Colp, George Joseph.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18962 )

Change subject: testuite: Python3 support ASTERISK-26826
......................................................................


Patch Set 4:

(6 comments)

File contrib/scripts/rlmi_demo.py:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/f86135ad_6f97bc7b 
PS3, Line 2: """Demonstration of parsing and print(ing RLMI XML document.
> printing?
Done


https://gerrit.asterisk.org/c/testsuite/+/18962/comment/1e39e610_4e35ed5a 
PS3, Line 26: print( 'list'
> Missing the closing ')
Done


File lib/python/asterisk/asterisk.py:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/7414cccf_beb4d57e 
PS3, Line 468:             reactor.callLater(2, __execute_wait_fully_booted)
> I'd add a comment here regarding 2
Done


File lib/python/asterisk/opensslversion.py:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/045965e2_5bda56ae 
PS3, Line 51: less 
> greater
Done


https://gerrit.asterisk.org/c/testsuite/+/18962/comment/955691fd_5033d045 
PS3, Line 51: less 
> greater
Done


File lib/python/asterisk/sipp.py:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/d56b7a38_06c9c97b 
PS3, Line 301:         reactor.callLater(1, self.do_start_callback)
> What's the purpose of the start callback here? Should it be documented its behavior that it doesn't  […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18962
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: Id22c8f7a89e2d00fca760970af63f3954c049bf3
Gerrit-Change-Number: 18962
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 19 Aug 2022 16:42:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220819/7c71213f/attachment.html>