[Asterisk-code-review] res_pjsip_pubsub: destroy old subscriptions on RLS update using seria... (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Alexei Gradinari.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18891 )

Change subject: res_pjsip_pubsub: destroy old subscriptions on RLS update using serializer
......................................................................


Patch Set 2:

(1 comment)

File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/c/asterisk/+/18891/comment/69d67558_56beebf2 
PS2, Line 4084: 						if (ast_sip_push_task(sub_tree->serializer, destroy_subscriptions_task, old_root)) {
> !@!@!@! thread1.txt !@!@!@! […]
I have a theory that it's not because the destruction is occurring in the wrong thread. What if notify_task was in queue to be executed after rx_pubsub_refresh? At that point in time the destruction would have taken place, but notify_task would still execute. Setting the state to terminated would cause notify_task to do nothing, fixing the issue. The change for pushing the destruction I don't think really fixes it.

That theory should be verified though.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18891
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I96582aad3a26515ca73a8460ee6756f56f6ba23b
Gerrit-Change-Number: 18891
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 15:37:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220816/1967d0bb/attachment-0001.html>