[Asterisk-code-review] res_pjsip_pubsub: destroy old subscriptions on RLS update using seria... (asterisk[16])
Alexei Gradinari
asteriskteam at digium.com
Tue Aug 16 10:11:33 CDT 2022
Attention is currently required from: Joshua Colp, N A.
Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18891 )
Change subject: res_pjsip_pubsub: destroy old subscriptions on RLS update using serializer
......................................................................
Patch Set 2:
(1 comment)
File res/res_pjsip_pubsub.c:
https://gerrit.asterisk.org/c/asterisk/+/18891/comment/fc56e192_b616d6ab
PS2, Line 4084: if (ast_sip_push_task(sub_tree->serializer, destroy_subscriptions_task, old_root)) {
> And to be more specific - the setting of the serializer on the dialog is done using ast_sip_dialog_s […]
!@!@!@! thread1.txt !@!@!@!
$1 = {si_signo = 11, si_errno = 0, si_code = 1, _sifields = {_pad = {-2094646068, 32612, 0 <repeats 26 times>}, _kill = {si_pid = -2094646068, si_uid = 32612}, _timer = {si_tid = -2094646068, si_overrun = 32612, si_sigval = {sival_int = 0, sival_ptr = 0x0}}, _rt = {si_pid = -2094646068, si_uid = 32612, si_sigval = {sival_int = 0, sival_ptr = 0x0}}, _sigchld = {si_pid = -2094646068, si_uid = 32612, si_status = 0, si_utime = 0, si_stime = 0}, _sigfault = {si_addr = 0x7f6483263ccc, _addr_lsb = 0, _addr_bnd = {_lower = 0x0, _upper = 0x0}}, _sigpoll = {si_band = 140069673778380, si_fd = 0}}}
Signal Stop Print Pass to program Description
SIGSEGV Yes Yes Yes Segmentation fault
Thread 1 (Thread 0x7f63f844f640 (LWP 14742)):
#0 __ao2_find (c=0x7f6483263cbc, arg=arg at entry=0x7f642fbea028, flags=flags at entry=OBJ_SEARCH_KEY, tag=tag at entry=0x60d438 "", file=file at entry=0x626f76 "datastore.c", line=line at entry=121, func=0x626fd0 <__PRETTY_FUNCTION__.2> "ast_datastores_find") at astobj2_container.c:437
arged = 0x7f642fbea028
#1 0x00000000004c999a in ast_datastores_find (datastores=<optimized out>, name=name at entry=0x7f642fbea028 "dialog-info+xml") at datastore.c:121
__PRETTY_FUNCTION__ = "ast_datastores_find"
#2 0x00007f642fbe84c8 in dialog_info_generate_body_content (body=0x7f6476e656c8, data=0x7f6430056e60) at res_pjsip_dialog_info_body_generator.c:111
dialog_info = 0x7f6476e656c8
dialog = <optimized out>
state = <optimized out>
datastore = <optimized out>
datastore_state = <optimized out>
state_data = 0x7f6430056e60
local = 0x7f63f844de50 "sip:244 at ......"
stripped = <optimized out>
statestring = 0x0
remote = 0x7f63f844de20 "sip:255 at ......"
pidfstate = 0x0
pidfnote = 0x0
local_state = NOTIFY_OPEN
version_str = "000000000000004", '000' <repeats 11 times>, "377377377377377377377377301000000000000000000"
sanitized = "000000000000000000000000260337D370c177000000000000000000d177000000000000000000000000000000f000000000000000000000340346D370c177", '000' <repeats 14 times>, "d177000000hr000000000000000000 000000000d177000000000000000000001000000000020000000000060000000000360345D370c177000000060345D370c177000000001000000000000000000000020000000000d177000000000000000000001000000000002000000000000000000000377377377377377377377377070b220254c177000000000000000000000000000000P340D370c177000000000000000000c177000000000000000000002000000000hr000000000000000000"...
endpoint = 0x0
notify_early_inuse_ringing = 0
__PRETTY_FUNCTION__ = "dialog_info_generate_body_content"
#3 0x00007f642fc54434 in ast_sip_pubsub_generate_body_content (type=0x7f642fbea111 "application", subtype=subtype at entry=0x7f642fbea028 "dialog-info+xml", data=data at entry=0x7f63f844ec30, str=str at entry=0x7f637405ccf8) at res_pjsip_pubsub.c:3587
supplement = <optimized out>
generator = 0x7f642fbec240 <dialog_info_body_generator>
res = 0
body = 0x7f6476e656c8
__FUNCTION__ = "ast_sip_pubsub_generate_body_content"
__PRETTY_FUNCTION__ = "ast_sip_pubsub_generate_body_content"
#4 0x00007f642fc54b3a in ast_sip_subscription_notify (sub=0x7f637405ccc0, notify_data=notify_data at entry=0x7f63f844ec30, terminate=0) at res_pjsip_pubsub.c:2582
res = <optimized out>
dlg = 0x7f6449725d48
__PRETTY_FUNCTION__ = "ast_sip_subscription_notify"
#5 0x00007f642fbdfc51 in notify_task (obj=0x7f6430056e60) at res_pjsip_exten_state.c:322
task_data = 0x7f6430056e60
data = {body_type = 0x7f642fbe289e "ast_sip_exten_state_data", body_data = 0x7f6430056e60}
#6 0x00000000005898a4 in ast_taskprocessor_execute (tps=tps at entry=0x5b7d100) at taskprocessor.c:1302
local = {local_data = 0x7f63f844ec70, data = 0x0}
t = 0x7f643002f080
size = <optimized out>
__PRETTY_FUNCTION__ = "ast_taskprocessor_execute"
#7 0x00000000005907d8 in execute_tasks (data=0x5b7d100) at threadpool.c:1350
tps = 0x5b7d100
#8 0x00000000005898a4 in ast_taskprocessor_execute (tps=0x2e299d0) at taskprocessor.c:1302
local = {local_data = 0x64a7b0, data = 0x64afc0 <__PRETTY_FUNCTION__.58>}
t = 0x7f63e483c660
size = <optimized out>
__PRETTY_FUNCTION__ = "ast_taskprocessor_execute"
#9 0x000000000059120f in threadpool_execute (pool=0x27e1f90) at threadpool.c:367
__PRETTY_FUNCTION__ = "threadpool_execute"
#10 worker_active (worker=0x7f6410009f90) at threadpool.c:1137
alive = <optimized out>
alive = <optimized out>
#11 worker_start (arg=arg at entry=0x7f6410009f90) at threadpool.c:1056
worker = 0x7f6410009f90
saved_state = <optimized out>
__PRETTY_FUNCTION__ = "worker_start"
#12 0x0000000000598b2d in dummy_start (data=<optimized out>) at utils.c:1574
__cancel_buf = {__cancel_jmp_buf = {{__cancel_jmp_buf = {0, -2001783446616141821, 140068266597038, 140068266597039, 0, 140067343758912, -2001871992448348157, 1941082490677497859}, __mask_was_saved = 0}}, __pad = {0x7f63f844ee30, 0x0, 0x1, 0x0}}
__cancel_routine = <optimized out>
__cancel_arg = 0x7f63f844f640
__not_first_call = <optimized out>
ret = <optimized out>
a = {start_routine = 0x590f30 <worker_start>, data = 0x7f6410009f90, name = 0x7f63f844ed90 ""}
__PRETTY_FUNCTION__ = "dummy_start"
#13 0x00007f6480c02e45 in start_thread () from /lib64/libpthread.so.0
No symbol table info available.
#14 0x00007f64807744af in clone () from /lib64/libc.so.6
No symbol table info available.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18891
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I96582aad3a26515ca73a8460ee6756f56f6ba23b
Gerrit-Change-Number: 18891
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 15:11:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220816/cd84c258/attachment-0001.html>
More information about the asterisk-code-review
mailing list