[Asterisk-code-review] res_pjsip: Add mediasec capabilities (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Maximilian Fridrich.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18837 )

Change subject: res_pjsip: Add mediasec capabilities
......................................................................


Patch Set 4: Code-Review-1

(11 comments)

File res/res_pjsip/security_agreements.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/aab66198_79b9e618 
PS4, Line 37: 	mech = ast_malloc(sizeof(struct ast_sip_security_mechanism));
If you use calloc then it will be automatically zeroed out.


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/8d5b36fa_02aafd7c 
PS4, Line 44: 	  ast_free(mech);
Indentation


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/4d79a9d8_02b3b5ed 
PS4, Line 60: 	dst = ast_sip_security_mechanisms_alloc(n_params);
This can fail


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/9cc5aa19_980444aa 
PS4, Line 89: 	if (AST_VECTOR_SIZE(dst) != 0) {
Indentation


File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/c208eef2_c0bc5044 
PS4, Line 596: 		(aor = ast_sip_location_retrieve_aor(endpt->aors)) &&
What happens if there are multiple AORs and contacts? The behavior should be documented somewhere


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/fd1918e5_f93c9619 
PS4, Line 609: 	if (client_state->status == SIP_REGISTRATION_REGISTERED || client_state->status == SIP_REGISTRATION_REJECTED_TEMPORARY 
Redness


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/e9da783e_88cadb3a 
PS4, Line 632: 		ao2_ref(endpt, -1);
Use ao2_cleanup


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/56950671_04bf5a4a 
PS4, Line 635: 		ao2_ref(reg, -1);
Use ao2_cleanup


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/e54cc0a8_63e0a2f3 
PS4, Line 1113: 			if (endpt) {
Same applies here as above


File res/res_pjsip_rfc3329.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/b92d4afb_ceee2048 
PS4, Line 74: 	if (contact_status) {
It's impossible for contact_status to be NULL here


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/8b59733e_496d6ae2 
PS4, Line 110: 	if (contact_status) {
It's impossible for contact_status to be NULL here



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18837
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia7f5b5ba42db18074fdd5428c4e1838728586be2
Gerrit-Change-Number: 18837
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 11:02:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220816/133d6625/attachment.html>