<p> Attention is currently required from: N A, Maximilian Fridrich. </p>
<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18837">View Change</a></p><p>11 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip/security_agreements.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/aab66198_79b9e618">Patch Set #4, Line 37:</a> <code style="font-family:monospace,monospace">     mech = ast_malloc(sizeof(struct ast_sip_security_mechanism));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">If you use calloc then it will be automatically zeroed out.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/8d5b36fa_02aafd7c">Patch Set #4, Line 44:</a> <code style="font-family:monospace,monospace">        ast_free(mech);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Indentation</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/4d79a9d8_02b3b5ed">Patch Set #4, Line 60:</a> <code style="font-family:monospace,monospace">  dst = ast_sip_security_mechanisms_alloc(n_params);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This can fail</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/9cc5aa19_980444aa">Patch Set #4, Line 89:</a> <code style="font-family:monospace,monospace">       if (AST_VECTOR_SIZE(dst) != 0) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Indentation</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_outbound_registration.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/c208eef2_c0bc5044">Patch Set #4, Line 596:</a> <code style="font-family:monospace,monospace">                (aor = ast_sip_location_retrieve_aor(endpt->aors)) &&</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">What happens if there are multiple AORs and contacts? The behavior should be documented somewhere</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/fd1918e5_f93c9619">Patch Set #4, Line 609:</a> <code style="font-family:monospace,monospace">    if (client_state->status == SIP_REGISTRATION_REGISTERED || client_state->status == SIP_REGISTRATION_REJECTED_TEMPORARY </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Redness</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/e9da783e_88cadb3a">Patch Set #4, Line 632:</a> <code style="font-family:monospace,monospace">         ao2_ref(endpt, -1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use ao2_cleanup</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/56950671_04bf5a4a">Patch Set #4, Line 635:</a> <code style="font-family:monospace,monospace">           ao2_ref(reg, -1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use ao2_cleanup</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/e54cc0a8_63e0a2f3">Patch Set #4, Line 1113:</a> <code style="font-family:monospace,monospace">                    if (endpt) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same applies here as above</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_pjsip_rfc3329.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/b92d4afb_ceee2048">Patch Set #4, Line 74:</a> <code style="font-family:monospace,monospace">    if (contact_status) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It's impossible for contact_status to be NULL here</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18837/comment/8b59733e_496d6ae2">Patch Set #4, Line 110:</a> <code style="font-family:monospace,monospace">  if (contact_status) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It's impossible for contact_status to be NULL here</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18837">change 18837</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18837"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ia7f5b5ba42db18074fdd5428c4e1838728586be2 </div>
<div style="display:none"> Gerrit-Change-Number: 18837 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Maximilian Fridrich <m.fridrich@commend.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Maximilian Fridrich <m.fridrich@commend.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 16 Aug 2022 11:02:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>