[Asterisk-code-review] res_hiredis: REDIS DeviceState and Dialplan functions (asterisk[master])

[Alec Davis]

Attention is currently required from: Sean Bright, N A, Joshua Colp.
Alec Davis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_hiredis: REDIS DeviceState and Dialplan functions
......................................................................


Patch Set 23:

(9 comments)

Patchset:

PS22: 
> Why do we no longer support unload?? […]
Ack


Patchset:

PS23: 
Patchset 23:

reworked module load to only load dialplan functions if subscription to status updates succeeded.

removed unnecessary is_enabled() in each of the Dialplan functions, as if the module isn't enabled then the dialplan functions are not registered.


File configs/samples/hiredis.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/03173d07_e8fbd295 
PS22, Line 2: enabled = yes                   ; When set to yes, hiredis support is enabled, default = no
> Since this is uncommented, this would default enable the support for anyone loading the module. […]
enabled = yes now commented out, so default of no kicks in.


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/d9e6d1c3_6b9e49f2 
PS22, Line 7: prefix = pabx:                  ; Prefix to prepend to all keypaths, default = ""
> I'm assuming PABX = Private Automatic Branch Exchange? Just seems like an odd prefix choice in a sam […]
Depends, not from our point of view.

I've renamed it to 'asterisk', but depends on what else is feeding the Redis Server


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/97c80742_aba020e0 
PS22, Line 11: background_save_on_unload = yes ; When set to yes, initiate a Background save when unloading module, default=no
> So you indicated you remove the unload option but this is still here - would this still be relevant?
Missed that, thanks.


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c7b6ec54_c776bff8 
PS22, Line 15: ;password = 12345678		; default = "", no authentication
> The other lines are indented using spaces but this uses tabs so the alignment is off
Done


File res/res_hiredis.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c3f41c99_3cab48f5 
PS20, Line 919: 	device_state_sub = stasis_subscribe(ast_device_state_topic_all(), device_state_cb, NULL);
> If this fails then this isn't going to work, and will confuse.
reworked, only is the subscription succeeds does it then load the dialplan functions


File res/res_hiredis.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/1a76ff6c_78fda06f 
PS22, Line 54: 			<example>
> The examples should have titles for each one that describe what they do, e.g. […]
The synopsis already explains that.


https://gerrit.asterisk.org/c/asterisk/+/18829/comment/eb2747bd_b31a81e6 
PS22, Line 854: 	return -1;
> In that case, I think it should at least be documented (e.g. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 23
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 06 Aug 2022 01:35:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Alec Davis <alec at bdt.co.nz>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220805/1e5f9b24/attachment-0001.html>