[Asterisk-code-review] features: Add transfer initiation options. (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18001 )

Change subject: features: Add transfer initiation options.
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

File include/asterisk/features_config.h:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/cb954016_dea33683 
PS4, Line 76: 		AST_STRING_FIELD(transferannouncesound);
This breaks ABI. Please use AST_STRING_FIELD_EXTENDED(transferannouncesound); at the end of the struct instead.

Then you'll need to initialize it with some like the following in the 'c' file:

ast_string_field_init_extended(<struct var>, transferannouncesound);

see stringsfields.h for more info


File main/features_config.c:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/bcfac686_bd811e02 
PS4, Line 1807: 	aco_option_register_custom(&cfg_info, "transferannouncesound", ACO_EXACT, global_options,
ast_string_field_init_extended(&cfg_info, transferannouncesound); will be needed here



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18001
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3
Gerrit-Change-Number: 18001
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 26 Apr 2022 21:39:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220426/c5a9ca38/attachment-0001.html>