<p> Attention is currently required from: N A. </p>
<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/18001">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/features_config.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18001/comment/cb954016_dea33683">Patch Set #4, Line 76:</a> <code style="font-family:monospace,monospace">               AST_STRING_FIELD(transferannouncesound);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This breaks ABI. Please use AST_STRING_FIELD_EXTENDED(transferannouncesound); at the end of the struct instead.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Then you'll need to initialize it with some like the following in the 'c' file:</p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_string_field_init_extended(<struct var>, transferannouncesound);</p><p style="white-space: pre-wrap; word-wrap: break-word;">see stringsfields.h for more info</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File main/features_config.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18001/comment/bcfac686_bd811e02">Patch Set #4, Line 1807:</a> <code style="font-family:monospace,monospace">   aco_option_register_custom(&cfg_info, "transferannouncesound", ACO_EXACT, global_options,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_string_field_init_extended(&cfg_info, transferannouncesound); will be needed here</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18001">change 18001</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18001"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3 </div>
<div style="display:none"> Gerrit-Change-Number: 18001 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Apr 2022 21:39:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>