[Asterisk-code-review] Changes required for Python 3 compatibility (starpy[1.1])

Kevin Harwell asteriskteam at digium.com
Mon Apr 25 16:30:35 CDT 2022


Attention is currently required from: Michael Bradeen.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/starpy/+/18244 )

Change subject: Changes required for Python 3 compatibility
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Commit Message:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/f6cadec6_d33b8f93 
PS2, Line 9: manager: Replace 'async' reference with 'nowait'.  This change breaks
           : backwards compatibility with previous versions of the testsuite,
           : requiring a matching change there.
Is there a way to make this change only for 3+ installs? Otherwise we're forcing ppl to upgrade even if they are running python2.7.

Also mention why the change as it took me a second to realize it.



-- 
To view, visit https://gerrit.asterisk.org/c/starpy/+/18244
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: starpy
Gerrit-Branch: 1.1
Gerrit-Change-Id: I2fab42abb5318a5db2af3bcd291fc2db95b87e15
Gerrit-Change-Number: 18244
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Mon, 25 Apr 2022 21:30:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220425/9384d45f/attachment.html>


More information about the asterisk-code-review mailing list