[Asterisk-code-review] Changes required for Python 3 compatibility (starpy[1.1])

Joshua Colp asteriskteam at digium.com
Tue Apr 12 05:44:03 CDT 2022


Attention is currently required from: Michael Bradeen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/starpy/+/18244 )

Change subject: Changes required for Python 3 compatibility
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/b232c604_54714c2e 
PS2, Line 7: Changes required for Python 3 compatibility
Better phrased as "Add support for Python 3"


Patchset:

PS2: 
Does this maintain Python 2 compatibility? I know from an API perspective this isn't backwards, so should we mention it in a README or something?



-- 
To view, visit https://gerrit.asterisk.org/c/starpy/+/18244
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: starpy
Gerrit-Branch: 1.1
Gerrit-Change-Id: I2fab42abb5318a5db2af3bcd291fc2db95b87e15
Gerrit-Change-Number: 18244
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 10:44:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220412/c072e478/attachment.html>


More information about the asterisk-code-review mailing list