[Asterisk-code-review] res_pjsip_header_funcs: Add functions PJSIP_REPLY_HEADER and PJSIP_RE... (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, José Lopes.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18367 )

Change subject: res_pjsip_header_funcs: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS1: 
> Thanks for the comments. I already fixed most of them, please review comment on one of the comments.
Ack


File res/res_pjsip_reply_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/321c26e0_5439d9af 
PS1, Line 49: 					may be appended to <replaceable>name</replaceable> to iterate over all 
> I don't understand what is wrong, but I improved by moving the sentence to the "name" parameter. […]
Ah, sorry for the vagueness... there was some trailing whitespace at the end of one of the lines. It looks like that's been fixed now.
Your XML is a bit off now which you can see in the Jenkins build:
 /usr/bin/xmllint --dtdvalid doc/appdocsxml.dtd --noout doc/core-en_US.xml
 doc/core-en_US.xml:17908: element note: validity error : Element note content does not follow the DTD, expecting (para+ | xi:include*), got (para example )
 Document doc/core-en_US.xml does not validate against doc/appdocsxml.dtd

<note> can only have <para> inside of it, I believe, so I think you may want to move the <example>s out of that.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18367
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I264a610a9333359297a0825feb29a1bb4f4ad144
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 2
Gerrit-Owner: José Lopes <jose.lopes at nfon.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: José Lopes <jose.lopes at nfon.com>
Gerrit-Comment-Date: Fri, 08 Apr 2022 15:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: José Lopes <jose.lopes at nfon.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220408/7c5a9e5a/attachment.html>