[Asterisk-code-review] res_pjsip_header_funcs: Add functions PJSIP_REPLY_HEADER and PJSIP_RE... (asterisk[master])

[José Lopes]

Attention is currently required from: N A, Joshua Colp.
José Lopes has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18367 )

Change subject: res_pjsip_header_funcs: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS
......................................................................


Patch Set 1:

(7 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/db1fd780_de2deda7 
PS1, Line 7: res_pjsip: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS
> This isn't res_pjsip, this is res_pjsip_header_funcs.
Ack


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/67cc8535_3a5867da 
PS1, Line 9: These new functions allows to retrieve information from Headers on 200 OK
> allow retrieving
Ack


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/2394a9a6_e8ca17ff 
PS1, Line 11: This code is based on res_pjsip_header_funcs.c .
> You should wrap your commit message at 72 chars. […]
Ack


Patchset:

PS1: 
Thanks for the comments. I already fixed most of them, please review comment on one of the comments.


File res/res_pjsip_reply_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/be65ccb4_c935ad22 
PS1, Line 7:  *
> Your information should go in here. Update the copyright, year, and author. […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/95d52af5_f0c25b38 
PS1, Line 49: 					may be appended to <replaceable>name</replaceable> to iterate over all 
> redness
I don't understand what is wrong, but I improved by moving the sentence to the "name" parameter. Let me know if I need to do more things.


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/d4155972_a8d7e92b 
PS1, Line 67: 			PJSIP channel.</para>
> Use the example XML tag instead of a bunch of para tags.
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18367
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I264a610a9333359297a0825feb29a1bb4f4ad144
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 1
Gerrit-Owner: José Lopes <jose.lopes at nfon.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 08 Apr 2022 15:49:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220408/a1c7d7e4/attachment.html>