[Asterisk-code-review] res_pjsip: Always set async_operations to 1. (asterisk[16])
Joshua Colp
asteriskteam at digium.com
Thu Apr 7 07:10:47 CDT 2022
Attention is currently required from: Richard Mudgett.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18365 )
Change subject: res_pjsip: Always set async_operations to 1.
......................................................................
Patch Set 1:
(1 comment)
File res/res_pjsip/config_transport.c:
https://gerrit.asterisk.org/c/asterisk/+/18365/comment/2463eb2b_81877c33
PS1, Line 493: ast_log(LOG_NOTICE, "The async_operations setting on transport '%s' has been set to '%d', this setting can no longer be set and is always 1\n",
> The async_operations setting on transport '%s' has been set to '%d'. […]
I don't know if we'll remove this, because removing options results in anyone who hasn't removed it from their configuration having a broken configuration. People SHOULD remove it, but it wouldn't surprise me if they don't and it's so minor that I'm not deadset on removing it.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18365
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1915973ef352862dc2852a6ba4cfce2ed536e68f
Gerrit-Change-Number: 18365
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 07 Apr 2022 12:10:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220407/1ee9be4d/attachment-0001.html>
More information about the asterisk-code-review
mailing list