[Asterisk-code-review] res_pjsip: Always set async_operations to 1. (asterisk[16])

[Richard Mudgett]

Attention is currently required from: Joshua Colp.
Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18365 )

Change subject: res_pjsip: Always set async_operations to 1.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

File res/res_pjsip/config_transport.c:

https://gerrit.asterisk.org/c/asterisk/+/18365/comment/45ef29d0_594a948f 
PS1, Line 493: 		ast_log(LOG_NOTICE, "The async_operations setting on transport '%s' has been set to '%d', this setting can no longer be set and is always 1\n",
The async_operations setting on transport '%s' has been set to '%d'.  The option can no longer be set and is always 1

I also think this should be a warning as the option should be removed in the future.


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18365/comment/a1b2cfa7_23034aab 
PS1, Line 1301: 					<synopsis>Number of simultaneous Asynchronous Operations, can no longer be set, always set to 1</synopsis>
May want to indicate that the option should be removed in the future.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18365
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1915973ef352862dc2852a6ba4cfce2ed536e68f
Gerrit-Change-Number: 18365
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 07 Apr 2022 12:03:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220407/1cf3c84c/attachment.html>