[Asterisk-code-review] apps/confbridge: Added hear_own_join_sound option to control who hear... (asterisk[16])

[Michael Cargile]

Attention is currently required from: Michael Bradeen, Sean Bright, N A, Kevin Harwell.
Michael Cargile has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18072 )

Change subject: apps/confbridge: Added hear_own_join_sound option to control who hears sound_join
......................................................................


Patch Set 8:

(5 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/a402a826_8684956f 
PS8, Line 10: control who hears the sound_join audio file. When set to 'yes' the user
> should this be join_sound?
The config option is "sound_join"


Patchset:

PS8: 
> The commit message and documentation reference sound_join instead of join_sound
Yes it does because the configuration option is called "sound_join"

Here is the section from the config file:

; All sounds in the conference are customizable using the bridge profile options below.
; Simply state the option followed by the filename or full path of the filename after
; the option.  Example: sound_had_joined=conf-hasjoin  This will play the conf-hasjoin
; sound file found in the sounds directory when announcing someone's name is joining the
; conference.

;sound_join  ; The sound played to everyone when someone enters the conference.
;sound_leave ; The sound played to everyone when someone leaves the conference.
;sound_has_joined ; The sound played before announcing someone's name has
                  ; joined the conference. This is used for user intros.
                  ; Example "_____ has joined the conference"
;sound_has_left ; The sound played when announcing someone's name has


File configs/samples/confbridge.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/a2a46c38_9fc55896 
PS8, Line 46:                           ; user will not hear the sound_join audio but the other participants
> join_sound
The config option is "sound_join"


https://gerrit.asterisk.org/c/asterisk/+/18072/comment/1b685e0f_a07a0213 
PS8, Line 48: j
> same
The config option is "sound_join"


File doc/CHANGES-staging/app_confbridge_hear_join.txt:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/aa737a28_5084b632 
PS8, Line 4: control who hears the sound_join audio file. When set to 'yes' the user
> join_sound
The config option is "sound_join"



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18072
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I856bd66dc0dfa057323860a6418c1371d249abd2
Gerrit-Change-Number: 18072
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Cargile <mikec at vicidial.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 05 Apr 2022 22:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220405/f7a6253f/attachment.html>