<p> Attention is currently required from: Michael Bradeen, Sean Bright, N A, Kevin Harwell. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/18072">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18072/comment/a402a826_8684956f">Patch Set #8, Line 10:</a> <code style="font-family:monospace,monospace">control who hears the sound_join audio file. When set to 'yes' the user</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">should this be join_sound?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The config option is "sound_join"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18072?tab=comments">Patch Set #8:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The commit message and documentation reference sound_join instead of join_sound</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes it does because the configuration option is called "sound_join"</p><p style="white-space: pre-wrap; word-wrap: break-word;">Here is the section from the config file:</p><p style="white-space: pre-wrap; word-wrap: break-word;">; All sounds in the conference are customizable using the bridge profile options below.<br>; Simply state the option followed by the filename or full path of the filename after<br>; the option. Example: sound_had_joined=conf-hasjoin This will play the conf-hasjoin<br>; sound file found in the sounds directory when announcing someone's name is joining the<br>; conference.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">;sound_join ; The sound played to everyone when someone enters the conference.<br>;sound_leave ; The sound played to everyone when someone leaves the conference.<br>;sound_has_joined ; The sound played before announcing someone's name has<br> ; joined the conference. This is used for user intros.<br> ; Example "_____ has joined the conference"<br>;sound_has_left ; The sound played when announcing someone's name has</pre></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File configs/samples/confbridge.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18072/comment/a2a46c38_9fc55896">Patch Set #8, Line 46:</a> <code style="font-family:monospace,monospace"> ; user will not hear the sound_join audio but the other participants</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">join_sound</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The config option is "sound_join"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18072/comment/1b685e0f_a07a0213">Patch Set #8, Line 48:</a> <code style="font-family:monospace,monospace">j</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">same</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The config option is "sound_join"</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File doc/CHANGES-staging/app_confbridge_hear_join.txt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/18072/comment/aa737a28_5084b632">Patch Set #8, Line 4:</a> <code style="font-family:monospace,monospace">control who hears the sound_join audio file. When set to 'yes' the user</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">join_sound</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The config option is "sound_join"</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/18072">change 18072</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/18072"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I856bd66dc0dfa057323860a6418c1371d249abd2 </div>
<div style="display:none"> Gerrit-Change-Number: 18072 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Michael Cargile <mikec@vicidial.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 05 Apr 2022 22:14:59 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Michael Bradeen <mbradeen@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>