[Asterisk-code-review] apps/confbridge: Added hear_own_join_sound option to control who hear... (asterisk[16])

Michael Bradeen asteriskteam at digium.com
Tue Apr 5 16:42:53 CDT 2022


Attention is currently required from: Sean Bright, N A, Michael Cargile, Kevin Harwell.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18072 )

Change subject: apps/confbridge: Added hear_own_join_sound option to control who hears sound_join
......................................................................


Patch Set 8:

(5 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/f3d17e25_c3111337 
PS8, Line 10: control who hears the sound_join audio file. When set to 'yes' the user
should this be join_sound?


Patchset:

PS8: 
The commit message and documentation reference sound_join instead of join_sound


File configs/samples/confbridge.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/d542ebf1_eb749b68 
PS8, Line 46:                           ; user will not hear the sound_join audio but the other participants
join_sound


https://gerrit.asterisk.org/c/asterisk/+/18072/comment/ce4d0081_807fe94b 
PS8, Line 48: j
same


File doc/CHANGES-staging/app_confbridge_hear_join.txt:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/e78802de_39ae0107 
PS8, Line 4: control who hears the sound_join audio file. When set to 'yes' the user
join_sound



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18072
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I856bd66dc0dfa057323860a6418c1371d249abd2
Gerrit-Change-Number: 18072
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Cargile <mikec at vicidial.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Michael Cargile <mikec at vicidial.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 05 Apr 2022 21:42:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220405/67947a3e/attachment.html>


More information about the asterisk-code-review mailing list