[Asterisk-code-review] apps/confbridge: Added hear_own_join_sound option to control who hear... (asterisk[16])

Michael Cargile asteriskteam at digium.com
Fri Apr 1 15:43:23 CDT 2022


Attention is currently required from: Sean Bright, N A, Kevin Harwell.
Michael Cargile has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18072 )

Change subject: apps/confbridge: Added hear_own_join_sound option to control who hears sound_join
......................................................................


Patch Set 8:

(3 comments)

Patchset:

PS8: 
Fixed the whitespace issue


File apps/confbridge/conf_config_parser.c:

https://gerrit.asterisk.org/c/asterisk/+/18072/comment/25098dc6_79818a4c 
PS7, Line 101:                                         <synopsis>Determines if the user also hears the join sound when they enter a conference</synopsis>
             :                                 </configOption>
> Use tabs for leading whitespace
fixed


https://gerrit.asterisk.org/c/asterisk/+/18072/comment/0cf584e3_9d3f5fcc 
PS7, Line 1581:                 u_profile.flags & USER_OPT_HEAR_OWN_JOIN_SOUND ?
              :                 "enabled" : "disabled");
> Use tabs for leading whitespace
fixed



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18072
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I856bd66dc0dfa057323860a6418c1371d249abd2
Gerrit-Change-Number: 18072
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Cargile <mikec at vicidial.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 01 Apr 2022 20:43:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220401/5db7fd7a/attachment-0001.html>


More information about the asterisk-code-review mailing list