[Asterisk-code-review] apps/app_playback.c: Add 'mix' option to app_playback (asterisk[16])

[Sean Bright]

Attention is currently required from: Joshua Colp, N A, Shloime Rosenblum, Kevin Harwell.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16540 )

Change subject: apps/app_playback.c: Add 'mix' option to app_playback
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

File apps/app_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/16540/comment/cbdcee49_4cd26f9f 
PS4, Line 55: 				<para>List of options (You can do Playback(filename,skipmix) or Playback(filename,mix|skip) but you can't use a comma as a delimeter).</para>
This line should be wrapped (it's too long)


https://gerrit.asterisk.org/c/asterisk/+/16540/comment/e3f35f9f_07b79836 
PS4, Line 499:                 	} else if (option_mix && strcasestr(front, ":") && !strcasestr(front, "://")) {				
There is trailing whitespace on this line.


https://gerrit.asterisk.org/c/asterisk/+/16540/comment/260f41be_6ac7ef15 
PS4, Line 496: 		if (option_say) {
             : 				res = say_full(chan, front, "", ast_channel_language(chan), NULL, -1, -1);
             :                   	/* If option mix check if it is in say format but not remote audio file */
             :                 	} else if (option_mix && strcasestr(front, ":") && !strcasestr(front, "://")) {				
             : 				res = say_full(chan, front, "", ast_channel_language(chan), NULL, -1, -1);
             : 			} else {
             : 				res = ast_streamfile(chan, front, ast_channel_language(chan));
             :                         }
The leading whitespace is mixed here (spaces & tabs) but should just be tabs.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16540
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a
Gerrit-Change-Number: 16540
Gerrit-PatchSet: 4
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 18:02:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210930/796c35e0/attachment.html>