<p> Attention is currently required from: Joshua Colp, N A, Shloime Rosenblum, Kevin Harwell. </p>
<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16540">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_playback.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16540/comment/cbdcee49_4cd26f9f">Patch Set #4, Line 55:</a> <code style="font-family:monospace,monospace">                              <para>List of options (You can do Playback(filename,skipmix) or Playback(filename,mix|skip) but you can't use a comma as a delimeter).</para></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This line should be wrapped (it's too long)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16540/comment/e3f35f9f_07b79836">Patch Set #4, Line 499:</a> <code style="font-family:monospace,monospace">                 } else if (option_mix && strcasestr(front, ":") && !strcasestr(front, "://")) {                             </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">There is trailing whitespace on this line.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16540/comment/260f41be_6ac7ef15">Patch Set #4, Line 496:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">              if (option_say) {<br>                             res = say_full(chan, front, "", ast_channel_language(chan), NULL, -1, -1);<br>                          /* If option mix check if it is in say format but not remote audio file */<br>                    } else if (option_mix && strcasestr(front, ":") && !strcasestr(front, "://")) {                             <br>                              res = say_full(chan, front, "", ast_channel_language(chan), NULL, -1, -1);<br>                  } else {<br>                              res = ast_streamfile(chan, front, ast_channel_language(chan));<br>                        }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The leading whitespace is mixed here (spaces & tabs) but should just be tabs.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16540">change 16540</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16540"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a </div>
<div style="display:none"> Gerrit-Change-Number: 16540 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Shloime Rosenblum <shloimerosenblum@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-CC: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: Shloime Rosenblum <shloimerosenblum@gmail.com> </div>
<div style="display:none"> Gerrit-Attention: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 30 Sep 2021 18:02:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>