[Asterisk-code-review] app_read: Fix null pointer crash (asterisk[16])

[Joshua Colp]

Attention is currently required from: Sean Bright, N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16548 )

Change subject: app_read: Fix null pointer crash
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

Patchset:

PS3: 
As well on another review I stated the commit message is not accurate, this remains true.


File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/16548/comment/0de80416_d6c7f982 
PS1, Line 157: 	char *terminator = NULL; /* use default terminator # by default */
> It wouldn't break anything per se, it's just that now the # character is being specified in multiple […]
I think it's splitting hairs at this point and would be safer doing it as Sean said. We've already seen how an assumption can cause a crash here, so if we can make it reasonably safe then I think doing so is good.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16548
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie941833e123c3dbfb88371b5de5edbbe065514ac
Gerrit-Change-Number: 16548
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 10:55:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210930/8dc54b61/attachment.html>