[Asterisk-code-review] app_read: Fix null pointer crash (asterisk[16])

[N A]

Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16548 )

Change subject: app_read: Fix null pointer crash
......................................................................


Patch Set 3:

(1 comment)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/16548/comment/ea619e58_de1fd1a0 
PS1, Line 157: 	char *terminator = NULL; /* use default terminator # by default */
> I don't see how it would break anything in app.c. The code in app.c says "if it's NULL use #" […]
It wouldn't break anything per se, it's just that now the # character is being specified in multiple places, rather than just one. Using NULL as the default was intentional, since that signifies "default" here. In reality, I can't see why the default would ever NOT be #, so maybe that's a bit pedantic here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16548
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie941833e123c3dbfb88371b5de5edbbe065514ac
Gerrit-Change-Number: 16548
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 19:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210929/a9578fdd/attachment.html>