[Asterisk-code-review] apps/app_playback.c: Add 'mix' option to app_playback (asterisk[16])

[Kevin Harwell]

Attention is currently required from: N A, Shloime Rosenblum.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16540 )

Change subject: apps/app_playback.c: Add 'mix' option to app_playback
......................................................................


Patch Set 3:

(1 comment)

File apps/app_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/16540/comment/fe74ad22_26875e8b 
PS3, Line 55: 				<para>List of options (You can do Playback(filename,skipmix) or Playback(filename,mix|skip) but you can't use a comma as a delimeter).</para>
> Playback has not (to my knowledge) ever had multiple options at once. […]
There appears to currently also be a third undocumented option named "say". This patch does now document that option though.

There may be dialplans out there that use the undocumented 'say' option along with one of the other options.

Even without that undocumented option the expectation is that a list of comma separated options is allowed (mutually exclusive or not), and should be adhered to by this patch. I do agree about the clunkiness of things though.

The other option is to make this a master only patch.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16540
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a
Gerrit-Change-Number: 16540
Gerrit-PatchSet: 3
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 22:13:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210929/2508be0f/attachment.html>