[Asterisk-code-review] apps/app_playback.c: Add 'mix' option to app_playback (asterisk[16])

[N A]

Attention is currently required from: Shloime Rosenblum, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16540 )

Change subject: apps/app_playback.c: Add 'mix' option to app_playback
......................................................................


Patch Set 3:

(1 comment)

File apps/app_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/16540/comment/ca1bf7c3_42a42cb8 
PS3, Line 55: 				<para>List of options (You can do Playback(filename,skipmix) or Playback(filename,mix|skip) but you can't use a comma as a delimeter).</para>
> If a comma separated list was allowed before, then no longer allowing such technically could break c […]
Playback has not (to my knowledge) ever had multiple options at once. The existing 2 options are mutually exclusive. Thus, you could do Playback(file,noanswer). Now that there are multiple options that can be used together, that will be a change in the way this app is used. Playback(file,noanswer,skip) won't get parsed as intended, since options will be "noanswer". I think if there are pipe-separated, it would work.

I think however this is done, it might seem a bit clunky in some way, but since the options aren't single letters, there has to be some way of differentiating them.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16540
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a
Gerrit-Change-Number: 16540
Gerrit-PatchSet: 3
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 21:46:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210929/f05d9f26/attachment-0001.html>