[Asterisk-code-review] app_read: Fix null pointer crash (asterisk[16])

[Sean Bright]

Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16548 )

Change subject: app_read: Fix null pointer crash
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/16548/comment/465aefb9_8ff26139 
PS1, Line 157: 	char *terminator = NULL; /* use default terminator # by default */
Change this to:

 char *terminator = "#";


https://gerrit.asterisk.org/c/asterisk/+/16548/comment/aabca343_f51a9ac1 
PS1, Line 216: 		if (!ast_strlen_zero(arglist.filename)) {
Why are we checking arglist.filename here?


https://gerrit.asterisk.org/c/asterisk/+/16548/comment/84e5707c_a3587e50 
PS1, Line 253: 					if (terminator && strchr(terminator, tmp[x-1])) {
This change is no longer necessary if you set terminator to # at declaration time.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16548
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie941833e123c3dbfb88371b5de5edbbe065514ac
Gerrit-Change-Number: 16548
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 18:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210929/ebce2312/attachment-0001.html>