<p> Attention is currently required from: N A. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16548">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File apps/app_read.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16548/comment/465aefb9_8ff26139">Patch Set #1, Line 157:</a> <code style="font-family:monospace,monospace"> char *terminator = NULL; /* use default terminator # by default */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Change this to:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> char *terminator = "#";</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16548/comment/aabca343_f51a9ac1">Patch Set #1, Line 216:</a> <code style="font-family:monospace,monospace">                if (!ast_strlen_zero(arglist.filename)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why are we checking arglist.filename here?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16548/comment/84e5707c_a3587e50">Patch Set #1, Line 253:</a> <code style="font-family:monospace,monospace">                                  if (terminator && strchr(terminator, tmp[x-1])) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This change is no longer necessary if you set terminator to # at declaration time.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16548">change 16548</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16548"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Ie941833e123c3dbfb88371b5de5edbbe065514ac </div>
<div style="display:none"> Gerrit-Change-Number: 16548 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 29 Sep 2021 18:26:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>