[Asterisk-code-review] chan_iax2: Add encryption for RSA authentication (asterisk[master])

[N A]

Attention is currently required from: George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15948 )

Change subject: chan_iax2: Add encryption for RSA authentication
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS5: 
> > I added one for MD5 to start, which was simple enough, but less certain about RSA. […]
All right, I've got the mechanics for this in place all right, not specifying file extensions and all, but the test suite path is getting truncated when it's running and thus the test fails for rsa:

[Sep 25 19:39:36] NOTICE[3682] chan_iax2.c: Unable to find private key '/tmp/asterisk-testsuite/0f9f9409e795d0cb6da8f033b55c6b81/run_5/ast1/etc/asteris'
[Sep 25 19:39:36] NOTICE[3682] chan_iax2.c: No way to send secret to peer '127.0.0.1' (their methods: 4)
[Sep 25 19:39:36] WARNING[3682] chan_iax2.c: I don't know how to authenticate guest69 to 127.0.0.1:4569
[Sep 25 19:39:36] VERBOSE[3753] dial.c: Called toguest69/1000
[Sep 25 19:39:36] VERBOSE[3753] chan_iax2.c: Hungup 'IAX2/toguest69-8822'

Indeed, looking in res_crypto.h, I can see the char array for "name" is defined to be of size 80: https://github.com/asterisk/asterisk/blob/master/res/res_crypto.c#L76

It looks like this needs to be increased? Would that be all right, or is there a different way? Oddly, the file path array is larger (256), but for some reason the limit here seems to be the name, not the path, though I wasn't aware they were separate things.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15948
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I18f1f9d7c59b4f9cffa00f3b94a4c875846efd40
Gerrit-Change-Number: 15948
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Sat, 25 Sep 2021 23:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210925/57280991/attachment.html>