[Asterisk-code-review] res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Sean Bright, George Joseph, Joe.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16160 )

Change subject: res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts
......................................................................


Patch Set 10:

(1 comment)

Patchset:

PS10: 
> Thanks. […]
Usually with the testsuite it's easiest to find another somewhat similar test (if possible), and start from there. Either it can give you ideas on how to implement your test, or you can sometimes even copy it, and add/change the things as you need. In a few cases it might even make sense to simply add your test case to an existing test (i.e extend a current one).

That said you might want to look into some of the tests that can be found under the pjsip inbound registration subdirectories:

https://github.com/asterisk/testsuite/tree/master/tests/channels/pjsip/registration/inbound

For instance:

https://github.com/asterisk/testsuite/tree/master/tests/channels/pjsip/registration/inbound/nominal/config_options/remove_existing

https://github.com/asterisk/testsuite/tree/master/tests/channels/pjsip/registration/inbound/nominal/multiple_contacts

Specifically you might be able to copy the remove_existing test case (just add your test(s) under the same "config_options" directory), changing only the relevant configuration options in the pjsip.conf file and possibly altering the "header matches" under the "ami-config" section in the yaml file.

Note, if you are able to go that route then in your file(s) you can remove all the v13.18.0 stuff (no longer applies for your test).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16160
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia2711b08f2b4d1177411b1be23e970d7fdff5784
Gerrit-Change-Number: 16160
Gerrit-PatchSet: 10
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Joe <ynadiv at corpit.xyz>
Gerrit-Comment-Date: Wed, 15 Sep 2021 18:25:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210915/b6f71daa/attachment.html>