[Asterisk-code-review] res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts (asterisk[16])

[Joe]

Attention is currently required from: Sean Bright, George Joseph, Kevin Harwell.
Joe has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16160 )

Change subject: res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts
......................................................................


Patch Set 10:

(1 comment)

Patchset:

PS10: 
> Those registration tests are pretty complicated. […]
Thanks.  I'm happy to help but this is my first time encountering the code of the testsuite and am a little lost.

Test #1 for remove_existing=yes:

So the way I've been testing this patch is by using 3 phones (we'll call them A,B,C) and setting max_contacts to 2.
Phone A registers and always stays online.
Phone B registers with expiration > A and goes offline.
Phone C registers and takes phone A's spot with the default behavior, and takes phone B's spot if remove_unavailable is enabled.

Test #2 for remove_existing=no:

This only requires 2 phones. Set max_contacts to 1.
Phone A registers and goes offline.
Phone B registers.  With default behavior, registration fails.  With remove_unavailable, phone B takes Phone A's spot.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16160
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia2711b08f2b4d1177411b1be23e970d7fdff5784
Gerrit-Change-Number: 16160
Gerrit-PatchSet: 10
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 09 Sep 2021 13:23:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210909/e5cea194/attachment-0001.html>