[Asterisk-code-review] resource_channels.c: Fix wrong external media parameter parse (asterisk[master])

[Kevin Harwell]

Attention is currently required from: Sungtae Kim.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16404 )

Change subject: resource_channels.c: Fix wrong external media parameter parse
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16404/comment/4e855819_59bb26c6 
PS2, Line 11: ASTERISK-29622
I ran Asterisk (18 at least) using the exact curl command on the issue, and it seemingly worked fine? That is I did not get the "{"message":"app cannot be empty"}" result with or without the patch applied.


File res/ari/resource_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/16404/comment/3ce5c1d8_1fa19f2e 
PS2, Line 2192: 	if (args->variables) {
              : 		struct ast_json *json_variables;
              : 
              : 		ast_ari_channels_external_media_parse_body(args->variables, args);
              : 		json_variables = ast_json_object_get(args->variables, "variables");
              : 		if (json_variables
              : 			&& json_to_ast_variables(response, json_variables, &variables)) {
              : 			return;
              : 		}
              : 	}
I'm missing something I think. Why does moving this code block to here alter the behavior?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16404
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I49509c48a6cbc0fb4165bfa4f834b5e8b9ace20d
Gerrit-Change-Number: 16404
Gerrit-PatchSet: 2
Gerrit-Owner: Sungtae Kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sungtae Kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 02 Sep 2021 16:41:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210902/e47bd95f/attachment.html>