<p> Attention is currently required from: Sungtae Kim. </p>
<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16404">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16404/comment/4e855819_59bb26c6">Patch Set #2, Line 11:</a> <code style="font-family:monospace,monospace">ASTERISK-29622</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I ran Asterisk (18 at least) using the exact curl command on the issue, and it seemingly worked fine? That is I did not get the "{"message":"app cannot be empty"}" result with or without the patch applied.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/ari/resource_channels.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16404/comment/3ce5c1d8_1fa19f2e">Patch Set #2, Line 2192:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">      if (args->variables) {<br>             struct ast_json *json_variables;<br><br>            ast_ari_channels_external_media_parse_body(args->variables, args);<br>         json_variables = ast_json_object_get(args->variables, "variables");<br>              if (json_variables<br>                    && json_to_ast_variables(response, json_variables, &variables)) {<br>                 return;<br>               }<br>     }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm missing something I think. Why does moving this code block to here alter the behavior?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16404">change 16404</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16404"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I49509c48a6cbc0fb4165bfa4f834b5e8b9ace20d </div>
<div style="display:none"> Gerrit-Change-Number: 16404 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sungtae Kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Sungtae Kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 02 Sep 2021 16:41:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>