[Asterisk-code-review] ast_coredumper: Refactor to better find things (asterisk[16])

[George Joseph]

Attention is currently required from: Michael Bradeen, Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16628 )

Change subject: ast_coredumper:  Refactor to better find things
......................................................................


Patch Set 2:

(3 comments)

Patchset:

PS1: 
> I am seeing similar too (Ubuntu 20.04). […]
Done


File contrib/scripts/ast_coredumper:

https://gerrit.asterisk.org/c/asterisk/+/16628/comment/a2398edb_41c22644 
PS1, Line 483: 		Mutually exclusive with --tartball-results
> Not from this patch, but while you're here s/tartball/tarball even though a tartball sounds quite de […]
Done


File contrib/scripts/ast_coredumper:

https://gerrit.asterisk.org/c/asterisk/+/16628/comment/d9ebd917_84e91725 
PS2, Line 91: 	die -20 "OUTPUTDIR ${OUTPUTDIR} doesn't exists or is not a directory"
> Do we want to create the directory if it doesn't exist instead of failing?

because the output files could be large and because i didn't want to take the chance of a user typo messing the system up, i decided to just bail if the directory didn't exist.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16628
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I674be64bdde3ef310b6a551d4911c3b600ffee59
Gerrit-Change-Number: 16628
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 28 Oct 2021 13:38:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211028/fdcb18ee/attachment-0001.html>