[Asterisk-code-review] ast_coredumper: Refactor to better find things (asterisk[16])

[Kevin Harwell]

Attention is currently required from: George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16628 )

Change subject: ast_coredumper:  Refactor to better find things
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS2: 
If I execute the script with basic parameters (same if I add more params), and select 'y' then I get the following:

$ sudo ./contrib/scripts/ast_coredumper --running
Found a single asterisk instance running as process 50230
WARNING:  Taking a core dump of the running asterisk instance will suspend call processing while the dump is saved.  Do you wish to continue? (y/N) y
date: extra operand ‘+%FT%H-%M-%S%z’
Try 'date --help' for more information.

This is on ubuntu 20.04


File contrib/scripts/ast_coredumper:

https://gerrit.asterisk.org/c/asterisk/+/16628/comment/bd351e4e_f2d76e82 
PS2, Line 91: 	die -20 "OUTPUTDIR ${OUTPUTDIR} doesn't exists or is not a directory"
Do we want to create the directory if it doesn't exist instead of failing?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16628
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I674be64bdde3ef310b6a551d4911c3b600ffee59
Gerrit-Change-Number: 16628
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 26 Oct 2021 23:28:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211026/715f58c5/attachment.html>