[Asterisk-code-review] app_assert: Add Assert application (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Mon Oct 25 18:20:05 CDT 2021


Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16629 )

Change subject: app_assert: Add Assert application
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> I guess what RaiseException and the e extension do is error handling, no? That's what I think of whe […]
I guess one person's error handling is another's assert :-)

Aside from the logging of the context, exten, and priority I don't see much difference between the two imo. Could extend RaiseException to have that though. I'll allow that readability is a difference too.

I'm sure this all feels like splitting hairs probably because it is, but naming is hard and many assumptions and expectations can be implied by such things.

This all may be a moot point anyway if others don't want the feature to go in at all, so I guess we can let others chime in with more opinions.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16629
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia089c2debf608f42f5f87e6c29d50e8ebcc093e5
Gerrit-Change-Number: 16629
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 25 Oct 2021 23:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211025/1b9177e9/attachment.html>


More information about the asterisk-code-review mailing list