[Asterisk-code-review] json: Add a object create with vars method and integer access macro (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Benjamin Keith Ford.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16642 )

Change subject: json: Add a object create with vars method and integer access macro
......................................................................


Patch Set 1:

(1 comment)

File include/asterisk/json.h:

https://gerrit.asterisk.org/c/asterisk/+/16642/comment/aeb2427d_1f155043 
PS1, Line 585:  * \brief Get an integer field from a JSON object.
             :  * \param integer JSON integer.
             :  * \return Value of a JSON integer.
             :  * \return 0 if \a integer is not a JSON integer.
> Do we care about \since here? This is going into multiple branches so not sure how you would want to […]
Not sure really. I personally don't, so left it out. It's kind of cumbersome in my opinion at this point with so many branches and which release it may or may not go in.

But I can add it in if folks really think it's needed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16642
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5f34f18e102126aef3997f19a553a266d70d6226
Gerrit-Change-Number: 16642
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Benjamin Keith Ford <bford at digium.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Fri, 22 Oct 2021 16:46:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211022/edd28284/attachment.html>