[Asterisk-code-review] json: Add a object create with vars method and integer access macro (asterisk[16])

[Benjamin Keith Ford]

Attention is currently required from: Kevin Harwell.
Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16642 )

Change subject: json: Add a object create with vars method and integer access macro
......................................................................


Patch Set 1:

(1 comment)

File include/asterisk/json.h:

https://gerrit.asterisk.org/c/asterisk/+/16642/comment/6a1236bd_9b7b7d20 
PS1, Line 585:  * \brief Get an integer field from a JSON object.
             :  * \param integer JSON integer.
             :  * \return Value of a JSON integer.
             :  * \return 0 if \a integer is not a JSON integer.
Do we care about \since here? This is going into multiple branches so not sure how you would want to do that if so. 16.22.0 I guess, or the 18 equivalent?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16642
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5f34f18e102126aef3997f19a553a266d70d6226
Gerrit-Change-Number: 16642
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Benjamin Keith Ford <bford at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 22 Oct 2021 13:12:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211022/7aaf7549/attachment.html>