[Asterisk-code-review] main/stun.c: fix crash upon STUN request timeout (asterisk[16])

[Sean Bright]

Attention is currently required from: Sébastien Duthil.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16579 )

Change subject: main/stun.c: fix crash upon STUN request timeout
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File main/stun.c:

https://gerrit.asterisk.org/c/asterisk/+/16579/comment/5a6c31fb_850ab405 
PS1, Line 242: 	const char *stun_server = "unknown server";
The server is not unknown to Asterisk, it is just unknown to this part of the code.

This is just going to confuse users. Better to just remove the STUN server from the message entirely if dst is NULL, so:

 Attempt %d to send STUN request timed out.

Instead of:

 Attempt %d to send STUN request to '%s' timed out.

If dst is NULL.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16579
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Idd9114c3380216ba48abfc3c68619e79ad37defc
Gerrit-Change-Number: 16579
Gerrit-PatchSet: 1
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Comment-Date: Thu, 14 Oct 2021 15:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211014/648dba0e/attachment.html>