<p> Attention is currently required from: Sébastien Duthil. </p>
<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/16579">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File main/stun.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16579/comment/5a6c31fb_850ab405">Patch Set #1, Line 242:</a> <code style="font-family:monospace,monospace">      const char *stun_server = "unknown server";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The server is not unknown to Asterisk, it is just unknown to this part of the code.</p><p style="white-space: pre-wrap; word-wrap: break-word;">This is just going to confuse users. Better to just remove the STUN server from the message entirely if dst is NULL, so:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> Attempt %d to send STUN request timed out.</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Instead of:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> Attempt %d to send STUN request to '%s' timed out.</pre><p style="white-space: pre-wrap; word-wrap: break-word;">If dst is NULL.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16579">change 16579</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16579"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Idd9114c3380216ba48abfc3c68619e79ad37defc </div>
<div style="display:none"> Gerrit-Change-Number: 16579 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sébastien Duthil <sduthil@wazo.community> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Sébastien Duthil <sduthil@wazo.community> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 14 Oct 2021 15:52:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>