[Asterisk-code-review] app_confbridge: New option to prevent answer supervision (asterisk[16])

[N A]

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15918 )

Change subject: app_confbridge: New option to prevent answer supervision
......................................................................


Patch Set 4:

> Patch Set 3: Code-Review-1
> 
> I think this should have a test[1][2] alongside the other ConfBridge tests.
> 
> [1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation
> [2] https://github.com/asterisk/testsuite/tree/master/tests/apps/confbridge

Thanks, I'll look into this. I'm reuploading the patch now to fix a bug, the option was inverted. Aware that I still need to add test cases. Since that's in a separate repo (testsuite), wouldn't that technically be a separate Gerrit change? But I'm assuming the test can be made independently even if it won't actually run in the current master branch.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15918
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I26642729d0345f178c7b8045506605c8402de54b
Gerrit-Change-Number: 15918
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 26 May 2021 22:19:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210526/43308df2/attachment.html>