<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this should have a test[1][2] alongside the other ConfBridge tests.</p><p style="white-space: pre-wrap; word-wrap: break-word;">[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+Test+Suite+Documentation<br>[2] https://github.com/asterisk/testsuite/tree/master/tests/apps/confbridge</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks, I'll look into this. I'm reuploading the patch now to fix a bug, the option was inverted. Aware that I still need to add test cases. Since that's in a separate repo (testsuite), wouldn't that technically be a separate Gerrit change? But I'm assuming the test can be made independently even if it won't actually run in the current master branch.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15918">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15918">change 15918</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15918"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I26642729d0345f178c7b8045506605c8402de54b </div>
<div style="display:none"> Gerrit-Change-Number: 15918 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 26 May 2021 22:19:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>