[Asterisk-code-review] app_confbridge: New option to prevent answer supervision (asterisk[16])

[N A]

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15918 )

Change subject: app_confbridge: New option to prevent answer supervision
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> (1 comment)
> 
> Out of curiosity, what's the use case for not answering the channel and how are you planning on answering it?  AMI?

So, if I'm understanding this right, just change USER_OPT_NOANSWER to USER_OPT_ANSWER_CHANNEL? It already defaults to yes rather than no, but I see how that's misleading there.

There are a lot of things in Asterisk that require ConfBridge for complicated things, especially because of the documented ChanSpy/Audiohooks limitation. My most common case is for a call with other audio in it. The reason for not answering immediately is answer supervision should not be provided until the called party has answered. Usually, I Progress() before the bridge so audio passes, and then if I want to answer, kick the channel out of the bridge, where it checks in a shared variable if we're supposed to answer the channel, then answers, then goes back into the bridge. Right now, I have ast_answer(chan) commented out completely in the source code in production as a workaround.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15918
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I26642729d0345f178c7b8045506605c8402de54b
Gerrit-Change-Number: 15918
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 21 May 2021 13:24:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210521/3bfa55e7/attachment.html>